Skip to content

Remove NoReturn #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

Remove NoReturn #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rosidl_generator_py/resource/_action.py.em
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,6 @@ class @(action.namespaced_type.name)(metaclass=Metaclass_@(action.namespaced_typ
# The generic message for get the status of a goal.
from action_msgs.msg._goal_status_array import GoalStatusArray as GoalStatusMessage

# type ignore below fixed in mypy 1.0+ see mypy#10342
def __init__(self) -> typing.NoReturn: # type: ignore
# Should eventually be typing.NoReturn. See mypy#14044
def __init__(self) -> None:
raise NotImplementedError('Action classes can not be instantiated')
4 changes: 2 additions & 2 deletions rosidl_generator_py/resource/_srv.py.em
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@ class @(service.namespaced_type.name)(metaclass=Metaclass_@(service.namespaced_t
from @('.'.join(service.namespaced_type.namespaces)).@(module_name) import @(service.response_message.structure.namespaced_type.name) as Response
from @('.'.join(service.namespaced_type.namespaces)).@(module_name) import @(service.event_message.structure.namespaced_type.name) as Event

# type ignore below fixed in mypy 1.0+ see mypy#10342
def __init__(self) -> typing.NoReturn: # type: ignore
# Should eventually be typing.NoReturn. See mypy#14044
def __init__(self) -> None:
raise NotImplementedError('Service classes can not be instantiated')