Skip to content

[kilted] Remove redudant numpy.array() backport #232 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

[kilted] Remove redudant numpy.array() backport #232 #236

merged 1 commit into from
Oct 1, 2025

Conversation

InvincibleRMC
Copy link
Contributor

@InvincibleRMC InvincibleRMC commented Sep 30, 2025 •
edited
Loading

Description

Backport of #232 for Kilted. This one should be more generally backportable I think.

Is this user-facing behavior change?

No

Did you use Generative AI?

Additional Information

@InvincibleRMC
backport fix
fafb7b9 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@fujitatomoya
Copy link
Contributor

fujitatomoya commented Sep 30, 2025 •
edited by ahcorde
Loading

Pulls: #236
Gist: https://gist.githubusercontent.com/fujitatomoya/f32220b3dc98dd00baad85c0ffd75b95/raw/d19a86df5ab9b60e0ff24e05bcaef12f4f4b2d1d/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17083

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Member

Note: it's good to include the original PR title in the backport PR title. Something like:

[kilted] Remove redudant numpy.array() (#232)

@InvincibleRMC InvincibleRMC changed the title Backport #232 [kilted] Remove redudant numpy.array() backport #232 Sep 30, 2025
@ahcorde ahcorde merged commit 9848f85 into ros2:kilted Oct 1, 2025
3 checks passed
@fujitatomoya
Copy link
Contributor

@Mergifyio backport jazzy humble

@mergify Mergify
Copy link

mergify bot commented Oct 2, 2025 •
edited
Loading

backport jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 2, 2025
@InvincibleRMC @mergify
[kilted] Remove redudant numpy.array() backport #232 #236
1a22548 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 9848f85)
@mergify mergify bot mentioned this pull request Oct 2, 2025
Merged
mergify bot pushed a commit that referenced this pull request Oct 2, 2025
@InvincibleRMC @mergify
[kilted] Remove redudant numpy.array() backport #232 #236
f5b7622 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
(cherry picked from commit 9848f85)
@mergify mergify bot mentioned this pull request Oct 2, 2025
Merged
@fujitatomoya
Copy link
Contributor

@InvincibleRMC thanks for the patch, no conflicts found against jazzy and humble.

ahcorde pushed a commit that referenced this pull request Oct 3, 2025
@mergify @InvincibleRMC
[kilted] Remove redudant numpy.array() backport #232 #236 (#240)
645f84a 
(cherry picked from commit 9848f85)

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: Michael Carlstrom <rmc@carlstrom.com>
ahcorde pushed a commit that referenced this pull request Oct 3, 2025
@mergify @InvincibleRMC
[kilted] Remove redudant numpy.array() backport #232 #236 (#239)
8580f74 
(cherry picked from commit 9848f85)

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: Michael Carlstrom <rmc@carlstrom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@InvincibleRMC @fujitatomoya @christophebedard @ahcorde