Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flake8 error #27

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Fix flake8 error #27

merged 1 commit into from
Jan 24, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jan 24, 2019

@sloretz sloretz added the in review Waiting for review (Kanban column) label Jan 24, 2019
@sloretz sloretz self-assigned this Jan 24, 2019
@sloretz sloretz merged commit 2149443 into master Jan 24, 2019
@sloretz sloretz deleted the flake_8_f999 branch January 24, 2019 16:27
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Jan 24, 2019
This was referenced Mar 8, 2019
Closed
Closed
nuclearsandwich pushed a commit that referenced this pull request Mar 10, 2019
@jacobperron @nuclearsandwich
Backport Python Actions (#32)
8a7f4b3 
* Adds Python typesupport for Actions (#21)

* Add _action.py.em; Makes rosidl_generator_py handle action files
properly

* Adds CMake pipeline bits for action generation.

* Fixes all linter issues.

* Attempts to fix CMake warnings in Windows.

* Fix flake8 error (#27)

* Provide type support for 'goal_status_array' in action type support

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Fix spelling typo

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Ignore import order on generated imports (#29)

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @mjcarroll