Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Python Actions #32

Merged
merged 5 commits into from
Mar 10, 2019
Merged

Backport Python Actions #32

merged 5 commits into from
Mar 10, 2019

Conversation

jacobperron
Copy link
Member

This PR syncs crystal with the head of master.
Replaces #31.

Alexis Pojomovsky and others added 5 commits January 14, 2019 15:33
@hidmic
Adds Python typesupport for Actions (#21)
29848db 
* Add _action.py.em; Makes rosidl_generator_py handle action files
properly

* Adds CMake pipeline bits for action generation.

* Fixes all linter issues.

* Attempts to fix CMake warnings in Windows.
@sloretz
Fix flake8 error (#27)
2149443
@jacobperron
Provide type support for 'goal_status_array' in action type support
80db10f 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Fix spelling typo
55f069e 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@sloretz
Ignore import order on generated imports (#29)
68e6271 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Mar 8, 2019
@sloretz sloretz mentioned this pull request Mar 8, 2019
Closed
@nuclearsandwich nuclearsandwich mentioned this pull request Mar 8, 2019
Closed
10 tasks
@nuclearsandwich
Copy link
Member

Only testing up to test_communication with the nested action PRs. This CI doesn't cover the other Python action PRs yet.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS (on Crystal instance) Build Status
  • Windows Build Status

nuclearsandwich
nuclearsandwich previously approved these changes Mar 8, 2019
View reviewed changes
@nuclearsandwich nuclearsandwich merged commit 8a7f4b3 into crystal Mar 10, 2019
@nuclearsandwich nuclearsandwich deleted the backport_python_actions branch March 10, 2019 02:44
@nuclearsandwich nuclearsandwich removed the in progress Actively being worked on (Kanban column) label Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @nuclearsandwich @sloretz