Ignore import order on generated imports #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
jacobperron
approved these changes
Feb 21, 2019
jacobperron
approved these changes
Feb 21, 2019
10 tasks
sloretz
added a commit
that referenced
this pull request
Mar 7, 2019
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
nuclearsandwich
pushed a commit
that referenced
this pull request
Mar 10, 2019
* Adds Python typesupport for Actions (#21) * Add _action.py.em; Makes rosidl_generator_py handle action files properly * Adds CMake pipeline bits for action generation. * Fixes all linter issues. * Attempts to fix CMake warnings in Windows. * Fix flake8 error (#27) * Provide type support for 'goal_status_array' in action type support Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix spelling typo Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Ignore import order on generated imports (#29) Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since actions are added separately from the generation of messages and services within them, it would be difficult to get the import order right. Instead this PR ignores the order
connects to ros2/rosidl#348
CI at ros2/rosidl_typesupport#44
required by ros2/rcl_interfaces#62
This PR should be backported to crystal