Type hashes in typesupport (rep2011) #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
14 tasks
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
|
Smoke check (one run with 3 PRs combined)
|
clalancette
reviewed
Mar 23, 2023
There was a problem hiding this comment.
If we end up taking my suggestion in ros2/rosidl#729 (review) , we'll need to update this PR as well. Otherwise it looks good to me.
wjwwood
approved these changes
Mar 23, 2023
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
|
Gist: https://gist.githubusercontent.com/emersonknapp/6f64e848cf178a828c180607a21fa967/raw/ba310891c24e6d45715e2fdd58d3a978b39d9442/ros2.repos
|
clalancette
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ros2/rosidl#729 (coupled - must be merged together)
Part of ros2/ros2#1159
Fill out new type_hash and message_type_support fields on generated
rosidl_message_type_support_tandrosidl_service_type_support_tstructs.