Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added benchmark test to rosidl_typesupport_c/cpp #84

Merged
merged 5 commits into from
Sep 25, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 16, 2020

Added benchmark test to rosidl_typesupport_c/cpp

With -DAMENT_RUN_PERFORMANCE_TESTS=ON:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the tests label Sep 16, 2020
@ahcorde ahcorde self-assigned this Sep 16, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
cottsay
cottsay previously approved these changes Sep 25, 2020
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My second point wasn't really addressed, but I'd like to move forward with getting this merged. We can follow up with more tests if we decide that the hot-copy case is something we'd like to track. Wrong PR 🤦

Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some fresh CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit f36cf14 into master Sep 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/benchmark/rosidl_typesupport_c branch September 25, 2020 16:09
ahcorde added a commit that referenced this pull request Oct 5, 2020
* Added benchmark test to rosidl_typesupport_c

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added benchmark test to rosidl_typesupport_cpp

Signed-off-by: ahcorde <ahcorde@gmail.com>

* reset heap counters

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Replace BENCHMARK_DEFINE_F and BENCHMARK_REGISTER_F with BENCHMARK_F

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed test

Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Oct 8, 2020
* Added benchmark test to rosidl_typesupport_c

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added benchmark test to rosidl_typesupport_cpp

Signed-off-by: ahcorde <ahcorde@gmail.com>

* reset heap counters

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Replace BENCHMARK_DEFINE_F and BENCHMARK_REGISTER_F with BENCHMARK_F

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed test

Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants