Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Fix failure when find-pkging Connext Module and c/cxx languages aren't enabled #55

Merged
merged 2 commits into from
May 19, 2020

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented May 19, 2020

Fixes osrf/docker_images#403.

We use Connext Module with two different purposes:

  • Just check if Connext is available (e.g. here).
  • Be able to compile/link against connext.

In the first case, variables like Connext_GLIBCXX_USE_CXX11_ABI_ZERO aren't of interest.

This PR does two changes:

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
…anguage support

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added bug Something isn't working in review Waiting for review (Kanban column) labels May 19, 2020
@ivanpauno ivanpauno self-assigned this May 19, 2020
@ivanpauno
Copy link
Member Author

ivanpauno commented May 19, 2020

Job config:

  • branch: ivanpauno/fix-failure-c-cxx-not-enabled
  • build: --packages-up-to rclcpp (to check that downstream packages build normally)
  • test: --packages-select connext_cmake_module
  • rmw implementations: Connext Static

Jobs (omitted arm64, connext not available there):

  • Linux Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 9fec59c into master May 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-failure-c-cxx-not-enabled branch May 19, 2020 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cmake issues with osrf/ros2:nightly-rmw-nonfree image tag
3 participants