Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redundant declarations in generated code for services and actions #102

Merged
merged 1 commit into from Jun 7, 2023
Merged

Avoid redundant declarations in generated code for services and actions #102

merged 1 commit into from Jun 7, 2023

Conversation

emersonknapp
Copy link
Contributor

Fixes #28

The typesupport code generation forward-declares used functions for the types of message member variables. However, for Services and Actions, these types' functions are already defined in the same source file, so the forward-declaration is redundant and raises a warning if -Wredundant-decls is enabled.

This patch fixes the redundant declarations, and adds the -Wredundant-decls compiler flag to catch it in the future

@emersonknapp
Avoid redundant declarations in generated code for services and actions
7c28ba7 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@clalancette clalancette mentioned this pull request Jun 6, 2023
Merged
clalancette
clalancette approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@emersonknapp
Copy link
Contributor Author

emersonknapp commented Jun 6, 2023 •
edited

Pulls: ros2/rosidl#750, ros2/rosidl_typesupport#145, #102
Gist: https://gist.githubusercontent.com/emersonknapp/c6789af2426c339278a67550f46ca634/raw/181d85f1ca93d4cbf3472e6379a59ffdbd47a395/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12163

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp emersonknapp mentioned this pull request Jun 6, 2023
Merged
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Jun 6, 2023 •
edited

Rerunning aarch64 Build Status

@clalancette clalancette merged commit 9c09ae8 into ros2:rolling Jun 7, 2023
3 checks passed
@emersonknapp
Copy link
Contributor Author

@Mergifyio backport iron humble

@mergify
Copy link

mergify bot commented Jun 7, 2023

backport iron humble

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@quarkytale
Copy link

@Mergifyio backport iron humble

@mergify
Copy link

mergify bot commented Jun 8, 2023 •
edited

backport iron humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 8, 2023
@emersonknapp @mergify
Avoid redundant declarations in generated code for services and actio…
76199c4 
…ns (#102)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 9c09ae8)
mergify bot pushed a commit that referenced this pull request Jun 8, 2023
@emersonknapp @mergify
Avoid redundant declarations in generated code for services and actio…
bed48cc 
…ns (#102)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 9c09ae8)

# Conflicts:
#	rosidl_typesupport_fastrtps_cpp/resource/srv__type_support.cpp.em
This was referenced Jun 8, 2023
Merged
Merged
clalancette pushed a commit that referenced this pull request Jun 27, 2023
@mergify
Avoid redundant declarations in generated code for services and actio…
b2de76a 
…ns (backport #102) (#104)

* Avoid redundant declarations in generated code for services and actions (#102)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 9c09ae8)
clalancette pushed a commit that referenced this pull request Jun 27, 2023
@mergify @emersonknapp
Avoid redundant declarations in generated code for services and actio…
2d264f3 
…ns (#102) (#103)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 9c09ae8)

Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rosidl generates redundant declarations
3 participants
@emersonknapp @quarkytale @clalancette