-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid redundant declarations in generated code for services and actions #102
Avoid redundant declarations in generated code for services and actions #102
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with green CI.
Pulls: ros2/rosidl#750, ros2/rosidl_typesupport#145, #102 |
@Mergifyio backport iron humble |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
@Mergifyio backport iron humble |
✅ Backports have been created
|
Fixes #28
The typesupport code generation forward-declares used functions for the types of message member variables. However, for Services and Actions, these types' functions are already defined in the same source file, so the forward-declaration is redundant and raises a warning if
-Wredundant-decls
is enabled.This patch fixes the redundant declarations, and adds the
-Wredundant-decls
compiler flag to catch it in the future