Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RVIZ_RENDERING_PUBLIC to export class RenderSystem #1072

Merged
merged 2 commits into from
Oct 9, 2023
Merged

RVIZ_RENDERING_PUBLIC to export class RenderSystem #1072

merged 2 commits into from
Oct 9, 2023

Conversation

felixf4xu
Copy link
Contributor

class RenderSystem is exported

this will fix #1069

@felixf4xu
Copy link
Contributor Author

@clalancette new commit added to remove the white space.

@clalancette
Copy link
Contributor

clalancette commented Oct 7, 2023 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Oct 9, 2023

warning is unrelated. Merging

@ahcorde ahcorde merged commit 55978d9 into ros2:rolling Oct 9, 2023
2 checks passed
@felixf4xu felixf4xu deleted the dll-export branch October 9, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

@clalancette clalancette Awaiting requested review from clalancette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RVIZ_RENDERING_PUBLIC for class member functions
3 participants
@felixf4xu @clalancette @ahcorde