-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement reset time service #1109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to fix uncrustify and cpplint ?
oops, I will check the cpplint and uncrustify. let you know when it finished thank you! have a good day according to this link uncrustify , do I need to recheck uncrustify also? |
0cc95f4
to
9f045b9
Compare
Hm, it's little strange... Both of result saying "Passed" in Jenkings Anyway, I confirmed that there was 1 error with cpplint on my local build environment.. |
|
9f045b9
to
4d9d19a
Compare
@ahcorde Hello, Cordero Could you review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahcorde Thank you |
I had hope the service for resetting time to utlize in the simulation environment and I've implemented.
There is resetting simulation scenario in my work.
This implementation provides ros2 service to reset the time in rviz2.
So now rviz2 can reset the time by short cut key(Ctrl+R #1088) or service call.
The service name is
/rviz/reset_time
.The time in rviz2 can be reset through below command.
ros2 service call /rviz/reset_time std_srvs/srv/Empty {}
I implemented the member function that it can reset time which is already added in #1088.
Just functionalize the code.