Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reset time service #1109

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Implement reset time service #1109

merged 1 commit into from
Dec 26, 2023

Conversation

hyunseok-yang
Copy link
Contributor

I had hope the service for resetting time to utlize in the simulation environment and I've implemented.
There is resetting simulation scenario in my work.

This implementation provides ros2 service to reset the time in rviz2.

So now rviz2 can reset the time by short cut key(Ctrl+R #1088) or service call.

The service name is /rviz/reset_time.

$ ros2 service list
/rviz/describe_parameters
/rviz/get_parameter_types
/rviz/get_parameters
/rviz/get_type_description
/rviz/list_parameters
/rviz/reset_time
/rviz/set_parameters
/rviz/set_parameters_atomically

The time in rviz2 can be reset through below command.

ros2 service call /rviz/reset_time std_srvs/srv/Empty {}

I implemented the member function that it can reset time which is already added in #1088.
Just functionalize the code.

@hyunseok-yang
Copy link
Contributor Author

@ahcorde
Hi, Cordero
Could you review my PR.
I think it is kind of extention work for #1088(Reset time by Ctrl+R).

I hope you can take a look if you have spare time :)

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to fix uncrustify and cpplint ?

@hyunseok-yang
Copy link
Contributor Author

hyunseok-yang commented Dec 21, 2023

Do you mind to fix uncrustify and cpplint ?

oops, I will check the cpplint and uncrustify.

let you know when it finished

thank you!

have a good day

according to this link uncrustify ,
it says passed.

do I need to recheck uncrustify also?

@hyunseok-yang
Copy link
Contributor Author

Do you mind to fix uncrustify and cpplint ?

oops, I will check the cpplint and uncrustify.

let you know when it finished

thank you!

have a good day

according to this link uncrustify , it says passed.

do I need to recheck uncrustify also?

Hm, it's little strange... Both of result saying "Passed" in Jenkings

image

image

Anyway, I confirmed that there was 1 error with cpplint on my local build environment..
I modified it and pushed again.
Let's see what Jenkin will say :)

@hyunseok-yang
Copy link
Contributor Author

Do you mind to fix uncrustify and cpplint ?

oops, I will check the cpplint and uncrustify.
let you know when it finished
thank you!
have a good day
according to this link uncrustify , it says passed.
do I need to recheck uncrustify also?

Hm, it's little strange... Both of result saying "Passed" in Jenkings

image

image

Anyway, I confirmed that there was 1 error with cpplint on my local build environment.. I modified it and pushed again. Let's see what Jenkin will say :)

Now I checked the failed case and will edit the code soon!
image

@hyunseok-yang
Copy link
Contributor Author

@ahcorde Hello, Cordero
I think latest changes are passed now :)

Could you review it?

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit a4f4de9 into ros2:rolling Dec 26, 2023
2 checks passed
@hyunseok-yang hyunseok-yang deleted the reset_service branch December 27, 2023 02:20
@hyunseok-yang
Copy link
Contributor Author

@ahcorde Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants