Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "R" key as shortcut for resetTime #1088

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

paulerikf
Copy link
Contributor

I find myself often wishing there was an easier way to easily "reset" rviz. I prefer to work with rviz in full-screen mode which exasperates the issue (as one must first minimize rviz, then click reset, then go back to full-screen).

For that reason, I've added key handling for the "R"-key to call resetTime.

Two questions from me:

  1. Is anyone else interested in this or am I weird?
  2. Is this an o.k. implementation?

@paulerikf paulerikf marked this pull request as draft November 15, 2023 14:44
@paulerikf paulerikf force-pushed the reset_hotkey branch 3 times, most recently from f16cee7 to 3496572 Compare November 15, 2023 20:03
@paulerikf
Copy link
Contributor Author

Also, any thoughts on this @ahcorde?

@hyunseok-yang
Copy link
Contributor

I hope this feature able to use in humble version of rviz2.
Any updates for that PR?

@paulerikf paulerikf marked this pull request as ready for review December 18, 2023 15:57
@paulerikf
Copy link
Contributor Author

Would love a quick review for this: @ahcorde

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit bb2ab95 into ros2:rolling Dec 20, 2023
2 checks passed
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-jazzy-jalisco-released/37862/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants