Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through CXX flags to OGRE vendor build #381

Merged
merged 3 commits into from
Mar 22, 2019
Merged

Pass through CXX flags to OGRE vendor build #381

merged 3 commits into from
Mar 22, 2019

Conversation

emersonknapp
Copy link
Contributor

@emersonknapp emersonknapp commented Mar 6, 2019 •
edited
Loading

Signed-off-by: Emerson Knapp eknapp@amazon.com

Related to ros2/ros2#664

@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Mar 6, 2019
@emersonknapp emersonknapp mentioned this pull request Mar 6, 2019
Merged
@nuclearsandwich

This comment has been minimized.

Sign in to view
@emersonknapp emersonknapp mentioned this pull request Mar 12, 2019
Closed
3 tasks
@nuclearsandwich
Copy link
Member

@emersonknapp it seems like this PR may introduce build failures on Mac OS. See https://ci.ros2.org/job/ci_osx/5313/consoleFull#console-section-257 from ros2/poco_vendor#24 (comment)

Emerson Knapp and others added 3 commits March 20, 2019 14:41
Pass through CXX flags
81d74e7 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@wjwwood
fixup
b2b7e11 
Signed-off-by: William Woodall <william@osrfoundation.org>
re-add removed libc++ flag, because OSX build always needs it
76b5b29 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Mar 20, 2019 •
edited
Loading

@nuclearsandwich Fixed with new update

@nuclearsandwich
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

nuclearsandwich
nuclearsandwich approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has passed CI.

@wjwwood I'm not sure if you also want to review this before I merge it?

@wjwwood wjwwood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 21, 2019
@nuclearsandwich nuclearsandwich merged commit 3344a8e into ros2:ros2 Mar 22, 2019
@nuclearsandwich nuclearsandwich removed the in review Waiting for review (Kanban column) label Mar 22, 2019
@emersonknapp emersonknapp deleted the libcxx branch March 22, 2019 16:04
@dirk-thomas
Copy link
Member

This change results in a bunch of new compiler warnings in this nightly job: https://ci.ros2.org/view/nightly/job/nightly_linux_coverage/440/warnings23Result/

Please address them soon.

@dirk-thomas dirk-thomas mentioned this pull request Mar 28, 2019
Closed
@nuclearsandwich
Copy link
Member

This change results in a bunch of new compiler warnings in this nightly job: ci.ros2.org/view/nightly/job/nightly_linux_coverage/440/warnings23Result

@emersonknapp I haven't looked into the issue yet. Is it something you'll have time to address as you continue with the thread safety annotations work?

@emersonknapp
Copy link
Contributor Author

emersonknapp commented Mar 29, 2019 •
edited
Loading

@nuclearsandwich I have started looking at this, tried to reproduce locally but haven't been able to yet

edit: i can reproduce locally and will put up a PR to fix soon

@emersonknapp emersonknapp mentioned this pull request Mar 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emersonknapp @nuclearsandwich @dirk-thomas @wjwwood @tfoote