Pass throug only the stdlib flag to the vendor build #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
added
in review
|
Are you able to run CI for this? There's a test job for nightlies (please don't run nightlies manually) here: |
… C++ flags Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
fix-nightly-warnings
branch
from
5d9bdca
to
28cfb4b
Compare
|
|
|
|
|
@wjwwood CI passed :) the first failed run was user error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of all C++ flags
Fixes warnings in nightly coverage build https://ci.ros2.org/view/nightly/job/nightly_linux_coverage/ that were introduced by #381
Signed-off-by: Emerson Knapp eknapp@amazon.com