[sros2_cmake] remove unnecessary build dependencies #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
added
in progress
mjcarroll
approved these changes
Mar 19, 2019
|
CI:
|
|
Is this targeted to dashing or should it be backported to crystal as well? |
|
thanks @mjcarroll for the review, this is pretty cosmetic so targeting only dashing is fine 👍 |
ryanewel
pushed a commit
to aws-ros-dev/sros2
that referenced
this pull request
Jun 12, 2019
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As these dependencies are used in the provided CMake macros but not needed for the build step of this package