Follow up 126: factor out hardcoded common name #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
kyrofa
reviewed
Jun 20, 2019
Is there a reason not to do that here? |
There were (still are?) ongoing PRs adding tests or touching tests using of the hard-coded common name when I wrote these commits. So I'd figure we'll let things settle a bit to then do a full search replace. |
Fair point, as long as we don't forget! 👍 |
mikaelarguedas
force-pushed
the
follow-up-126
branch
from
a2f4b0f
to
0f7cdbb
Compare
This reverts commit 3a45a75. Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
force-pushed
the
follow-up-126
branch
from
0f7cdbb
to
fdc0826
Compare
Opened #137 so that we don't 👍 |
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
|
ruffsl
pushed a commit
to ruffsl/sros2
that referenced
this pull request
Aug 6, 2019
* use upper case names for constants Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * factor out hardcoded common name Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * avoid using python builtins as argument names Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * Revert "use upper case names for constants" This reverts commit 3a45a75. Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * format cnf string to be more readable Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * make DEFAULT_COMMON_NAME private Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factors out the hardcoded
sros2testCAinto a constantDEFAULT_COMMON_NAME.Once this is merged, the tests checking for the common name can be updated to leverage this new constant as well.
Long term, this should likely be exposed to users so that they can pick the name used instead of this hardcoded one