Fix name of argument passed to NodeStrategy #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeStrategy does not look for an argument named 'use_daemon'. Instead it checks for an argument named 'no_daemon'. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
Jul 6, 2020
|
For reference: |
mikaelarguedas
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
thanks for the catch
CI failure is unrelated and likely another occurrence of https://github.com/ros2/sros2/issues/221
I re-triggered the failing workflow
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 76.84% 76.84%
=======================================
Files 23 23
Lines 609 609
Branches 53 53
=======================================
Hits 468 468
Misses 121 121
Partials 20 20
Continue to review full report at Codecov.
|
|
Permalink for the reference from #227 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226
NodeStrategy does not look for an argument named 'use_daemon'.
Instead it checks for an argument named 'no_daemon'.
macOS (retest-until-fail 10):