Windows tutorial tweaks #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`set` instead of `export` use `bat` for cmd.exe highlighting Remove trailing backticks Add note about RANDFILE
sloretz
added
in review
mikaelarguedas
approved these changes
Jun 22, 2018
| ```bash | ||
| curl -sk https://raw.githubusercontent.com/ros2/sros2/ardent/examples/sample_policy.yaml -o .\demo_keys\policies.yaml | ||
| ```bat | ||
| curl -k https://raw.githubusercontent.com/ros2/sros2/ardent/examples/sample_policy.yaml -o .\demo_keys\policies.yaml |
There was a problem hiding this comment.
Is this because we want additional printing if the download fail?
Or did something else motivate this change?
There was a problem hiding this comment.
In my case -s was hiding an error saying curl was not built with https support, and I almost didn't notice due to #41. By chance I saw the file wasn't there when deleting the demo_keys directory for another RMW implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setinstead ofexportbatfor cmd.exe highlightingRANDFILE-soption from curl (my installation of curl fails because it doesn't support https, and slient hides this)