Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foxy-backport] add cyclonedds to the list of rmw using graph info topics (#231) #238

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

mikaelarguedas
Copy link
Member

As CycloneDDS security has been made available in Foxy (and synced to main already)

@kyrofa
Copy link
Member

kyrofa commented Sep 2, 2020

I see that cyclonedds is using release/0.7.x in foxy, but if I look at the changelog there I don't actually see security-related things. I do on master, but that's not what's in Foxy. I'm obviously missing a piece of the puzzle, can you show me?

@mikaelarguedas
Copy link
Member Author

but if I look at the changelog there I don't actually see security-related things.

I guess the missing piece is that the changelog on the 0.7.X branch is missing the 0.7.0 entry (which is somehow ironic).
The one on master has the changelog of version 0.7.0 which is the one that's in Foxy and includes the bits about security support.

Copy link
Member

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I should have looked at rosdistro, okay fair enough, thank you. Great to see this come to Foxy!

@mikaelarguedas
Copy link
Member Author

Opened a PR against the changelogs to avoid future confusion

The ROS buildfarm CI failure is due to connectivity issue updating rosdep database and is unrelated to this change

Copy link

@artivis artivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants