-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip mypy test on centos 7 (alternative) #248
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
looks like CI doesn't install dependencies based on package.xml data. @clalancette is it possible to get rospkg installed on CI machines ? |
Ah, I forgot about that. While I could certainly open a PR to https://github.com/ros2/ci to add
I'd go for 3) personally, but I'd like to hear other opinions. |
could the documentation use rosdep for that? Does the fact that Red Hat announced discontinuation of CentOS impact the final decision? |
Ditto @mikaelarguedas's thoughts. Preference for (2), not sure it makes sense to invest in a platform that is disappearing. |
I don't think so. As far as I know, CentOS is not discontinued; it is just changed. Also, there are several new distributions popping up to fill the place that CentOS occupied. So while CentOS as it is today may go away, I think that there will be some RHEL-compatible clone (or RHEL itself) that we target. |
@clalancette thanks for clarifying. Is there a path forward for 1) (streamlining installing deps using rosdep) or do you believe we have to fall back to 3) (duplicate rospkg logic in this package) ? |
Since the problem this PR is trying to avoid is actually caused by the use if Also, RHEL 8 is also using Python < 3.9 and is therefore using the |
Replaced by #258 |
Replaces #246 and uses rospkg to avoid duplicating os-release parsing logic.