-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for 'best available' QoS policies #501
Conversation
Testing feature added in ros2/rmw#320 for all supported rmw implementations. Test creating a subscription and publisher with 'best available' policies and confirm the actual QoS policies are what we expect (adapting to an existing endpoint). Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Right now the feature is only implemented for |
After implementing the support for connext and cyclone, my local system is displaying some problems with fastrtps:
Might be related to the new check in https://github.com/ros2/rmw_fastrtps/pull/598/files#diff-718816e7845a1f3a980129f39e3146e30d65eec32f452c1c47de051bf42717d1R74 ? Uncrustify is also reporting to need a patch, although seems not very nice to me: --- test/test_best_available.cpp
+++ test/test_best_available.cpp
@@ -37,5 +37,5 @@
- .best_effort()
- .transient_local()
- .deadline(publisher_deadline)
- .liveliness(rclcpp::LivelinessPolicy::Automatic)
- .liveliness_lease_duration(publisher_liveliness_lease_duration);
+ .best_effort()
+ .transient_local()
+ .deadline(publisher_deadline)
+ .liveliness(rclcpp::LivelinessPolicy::Automatic)
+ .liveliness_lease_duration(publisher_liveliness_lease_duration);
@@ -89,5 +89,5 @@
- .best_effort()
- .durability_volatile()
- .deadline(subscription_deadline)
- .liveliness(rclcpp::LivelinessPolicy::ManualByTopic)
- .liveliness_lease_duration(subscription_liveliness_lease_duration);
+ .best_effort()
+ .durability_volatile()
+ .deadline(subscription_deadline)
+ .liveliness(rclcpp::LivelinessPolicy::ManualByTopic)
+ .liveliness_lease_duration(subscription_liveliness_lease_duration); |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@j-rivero I'm not able to reproduce the test failure you are seeing. I can run the test for all rmw implementations without error. Double check that you have all of the connected PRs checkout out and that they are up-to-date 🤷 |
I've added a couple tests to check that services and clients can be created with best available policies: 4accd1a |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
52de9e3
to
4accd1a
Compare
Testing feature added in ros2/rmw#320 for all supported rmw implementations.
Test creating a subscription and publisher with 'best available' policies and confirm the actual
QoS policies are what we expect (adapting to an existing endpoint).