Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy] Export YAML_CPP_DLL define on Windows #30

Merged
merged 1 commit into from
Feb 16, 2022
Merged

[foxy] Export YAML_CPP_DLL define on Windows #30

merged 1 commit into from
Feb 16, 2022

Conversation

Ace314159
Copy link
Contributor

Fixes #10

@Ace314159
Export YAML_CPP_DLL define on Windows
58e6746 
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
@Ace314159 Ace314159 mentioned this pull request Feb 3, 2022
Merged
@clalancette clalancette mentioned this pull request Feb 3, 2022
Closed
jacobperron
jacobperron approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows: Build Status (unrelated issues)

@jacobperron jacobperron added this to Proposed in Foxy Patch Release 8 via automation Feb 16, 2022
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 8 Feb 16, 2022
@jacobperron jacobperron moved this from Needs backport to Needs release in Foxy Patch Release 8 Feb 16, 2022
@jacobperron jacobperron merged commit efe5371 into ros2:foxy Feb 16, 2022
@jacobperron
Copy link
Member

I was mistaken, the MSBuild warnings are related to this change. Hopefully, we can get the patches mentioned here #31 (comment) backported to Foxy.

jacobperron added a commit that referenced this pull request Sep 12, 2022
@jacobperron
Revert "Export YAML_CPP_DLL define on Windows (#30)"
52f26fe 
This reverts commit efe5371.
@jacobperron
Copy link
Member

Reverting this change in #37

@Ace314159 Ace314159 mentioned this pull request Sep 13, 2022
Closed
jacobperron pushed a commit that referenced this pull request Sep 20, 2022
@Ace314159 @jacobperron
Export YAML_CPP_DLL define on Windows (#30)
c9e73b6 
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
jacobperron pushed a commit that referenced this pull request Sep 20, 2022
@Ace314159 @jacobperron
Export YAML_CPP_DLL define on Windows (#30)
bf149f1 
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
This was referenced Sep 20, 2022
Merged
Open
@jacobperron jacobperron moved this from Needs release to Done in Foxy Patch Release 8 Sep 23, 2022
jacobperron added a commit that referenced this pull request Oct 4, 2022
@jacobperron @Ace314159
Export YAML_CPP_DLL define on Windows (#30) (#38)
b813bbe 
* Use target name directly instead of variable
* Add comment explaining why we are setting YAML_CPP_DLL

Co-authored-by: Akash <Ace314159@users.noreply.github.com>
Signed-off-by: Akash Munagala <akash.munagala@gmail.com>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Foxy Patch Release 8
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ace314159 @jacobperron