Add Bazel build for message_generation #66
Conversation
This also allows other Bazel projects to include rosjava_core as an external repository, as instructed in README.md. This uses https://github.com/johnynek/bazel-deps to describe the Maven dependencies. As a result, 3rdparty/ contains autogenerated files, and the other files contain a hand-written description of the BUILD. DO NOT MERGE until rosjava/rosjava_bootstrap#66 has been merged.
|
@jubeira @damonkohler If you can point me at the gradle configuration that adds the message files to the resources, I can try to do the same for Bazel. |
|
@drigz sorry, I'm not familiar with that Gradle task. The message files are already in the |
This also allows other Bazel projects (rosjava_core in particular) to depend on this as an external repository. It uses https://github.com/johnynek/bazel-deps to describe the Maven dependencies. As a result, 3rdparty/ contains autogenerated files, and the other files contain a hand-written description of the BUILD. Only some of the tests in message_generation have been added. The others fail at the moment because the .msg resources aren't present. I will add documentation for the Bazel build to rosjava_core.
|
@jubeira Thanks, that was easier than I thought! |
There was a problem hiding this comment.
I'm not that familiar with Bazel builds, so in this case I trust your judgement.
The only high level comment I have is the version used for the dependencies. Does Bazel use semantic versioning? Perhaps it would be better to use a range of versions as in Gradle buildscripts.
|
Nope, bazel-deps doesn't support version ranges: bazeltools/bazel-deps#46 @ensonic Could you review the (non-auto-generated) Bazel files here? |
|
Thank you both! |
This also allows other Bazel projects (rosjava_core in particular) to
depend on this as an external repository.
It uses https://github.com/johnynek/bazel-deps to describe the Maven
dependencies. As a result, 3rdparty/ contains autogenerated files, and
the other files contain a hand-written description of the BUILD.
Only some of the tests in message_generation have been added. The others
fail at the moment because the .msg resources aren't present.
I will add documentation for the Bazel build to rosjava_core.