-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for population selection based on predictive/posterior probabilities in getSimulationEnrichmentMeans/Rates/Survival #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev/3.5.0
# Conflicts: # R/f_core_assertions.R # R/f_design_group_sequential.R # R/f_simulation_performance_score.R # man-roxygen/examples_get_performance_score.R # man/getPerformanceScore.Rd # tests/testthat/test-f_simulation_performance_score.R
Use R6 instead of reference classes
# Conflicts: # R/class_analysis_results.R # R/class_summary.R
fix SummaryItem
Relocated to issue [#32] since it didn't include any code changes, making the issues section more appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am wondering if it would be possible to add an additional option (e.g,
userDefined
) for the argumenteffectMeasure
ingetSimulationEnrichmentMeans/Rates/Survival
, to allow a user defined function based on effect measures other thaneffectEstimate
andtestStatistic
forselectPopulationsFunction
. Examples for such alternatives are population-specific predictive probabilities and subgroup-specific posterior probabilities1. This might be implemented by providing additional arguments for the customized functionselectPopulationsFunction
to facilitate the calculation for both type of probabilities.Just a thought for consideration: it may be convenient to borrow some arguments from
calcSubjectsFunction
(customized function for sample size re-calculation), but to provide for populations as well as subgroups. To be specific, we may needFootnotes
Brannath, W., Zuber, E., Branson, M., Bretz, F., Gallo, P., Posch, M., and Racine-Poon, A. (2009), “Confirmatory adaptive designs with Bayesian decision tools for a targeted therapy in oncology,” Statistics in Medicine, 28, 1445–1463. ↩