Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in computing the length of the trajectory #36

Closed
ZuoJiaxing opened this issue Feb 28, 2020 · 2 comments
Closed

Issues in computing the length of the trajectory #36

ZuoJiaxing opened this issue Feb 28, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@ZuoJiaxing
Copy link

The function to compute the length of the trajectory is wrong:

double Loader::get_total_length(const std::vector<Eigen::Matrix<double,7,1>> &poses) {

@goldbattle goldbattle added the debugging Might be a bug, looking into the issue label Feb 28, 2020
@goldbattle
Copy link
Member

The norm of the quaternion should be one, so this should be fine if as is.
It should probably be changed to explicitly norm just the position component for clarity.
Is this the issue that you are referring to?

@goldbattle goldbattle added bug Something isn't working and removed debugging Might be a bug, looking into the issue labels Feb 28, 2020
@goldbattle
Copy link
Member

The norm of the difference of two quaternions is not still restrained to be one. Fixed in the latest commit. Reopen if this was not the issue. We would appreciate it if you provide more details of the error in the future, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants