This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Updates from rspec-dev (2014-11-13) #1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Explicitly clear `ANSICON` ENV var in the context concerning when it’s not set. On appveyor we install ANSICON so it is in fact normally set. - Move the specs out of the context that sets `config.color = true` in a `before` hook. This was causing problems because it triggered warnings before our `allow_warnings` code had a chance to silence them.
- Skip specs that rely on shell escaping (not available on windows). - On windows we wrap all args in single quotes, so change our expectations to allow for that.
This should (hopefully) fix the rake task specs on windows.
myronmarston
force-pushed
the
update-travis-build-scripts-2014-11-13-for-master
branch
2 times, most recently
from
145e007 to
7c94a14
Compare
myronmarston
force-pushed
the
update-travis-build-scripts-2014-11-13-for-master
branch
from
7c94a14 to
9a8a5a2
Compare
myronmarston
added a commit
that referenced
this pull request
Nov 14, 2014
…11-13-for-master Updates from rspec-dev (2014-11-13)
myronmarston
deleted the
update-travis-build-scripts-2014-11-13-for-master
branch
|
Got the build green: https://ci.appveyor.com/project/myronmarston/rspec-core/build/121 |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…2014-11-13-for-master Updates from rspec-dev (2014-11-13)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some updates, generated from rspec-dev's rake tasks.