This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Fix documentation for nested described_class #2629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rspec#2627 Documentation for `described_class` was out of date, a change was made in early 3.0 in rspec#1361, but was not reflected to the docs. Also, documentation for implicit `subject` was off, even though there is a feature describing how it behaves.
|
Any suggestion how to deal with Ruby 2.2 Rails 5.0 build failure in It seems that Ruby dependency was bumped quite a while ago already. |
myronmarston
approved these changes
May 27, 2019
|
Awesome, thanks! |
pirj
added a commit
to pirj/rubocop-rspec
that referenced
this pull request
Jul 5, 2019
RSpec is actually setting the innermost described class as `described_class`, not the top-level one: rspec/rspec-core#2627 rspec/rspec-core#2629 https://github.com/rspec/rspec-core/blob/master/Changelog.md#300rc1--2014-05-18 > Breaking Changes for 3.0.0: > Change described_class so that in a nested group like describe > MyClass, it returns MyClass rather than the outer group's described > class.
pirj
added a commit
to pirj/rubocop-rspec
that referenced
this pull request
Jul 10, 2019
RSpec is actually setting the innermost described class as `described_class`, not the top-level one: rspec/rspec-core#2627 rspec/rspec-core#2629 https://github.com/rspec/rspec-core/blob/master/Changelog.md#300rc1--2014-05-18 > Breaking Changes for 3.0.0: > Change described_class so that in a nested group like describe > MyClass, it returns MyClass rather than the outer group's described > class.
pirj
added a commit
to pirj/rubocop-rspec
that referenced
this pull request
Jul 10, 2019
RSpec is actually setting the innermost described class as `described_class`, not the top-level one: rspec/rspec-core#2627 rspec/rspec-core#2629 https://github.com/rspec/rspec-core/blob/master/Changelog.md#300rc1--2014-05-18 > Breaking Changes for 3.0.0: > Change described_class so that in a nested group like describe > MyClass, it returns MyClass rather than the outer group's described > class.
5 tasks
|
Done.
…On Sun, Aug 4, 2019 at 5:54 AM Phil Pirozhkov ***@***.***> wrote:
Is it possible to update 3-8-maintenance branch with this change? It's
still outdated on Relish (1
<https://relishapp.com/rspec/rspec-core/v/3-8/docs/metadata/described-class>,
2
<https://relishapp.com/rspec/rspec-core/v/3-8/docs/subject/implicitly-defined-subject>
).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2629?email_source=notifications&email_token=AAAMB35GHN33CQG3O6LSJP3QC3GRHA5CNFSM4HPVH232YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3QBHOY#issuecomment-518001595>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAMB37GUPCN56GBBPLXEPLQC3GRHANCNFSM4HPVH23Q>
.
|
|
Thanks @myronmarston :) |
kellysutton
pushed a commit
to kellysutton/rubocop-rspec
that referenced
this pull request
Oct 28, 2019
RSpec is actually setting the innermost described class as `described_class`, not the top-level one: rspec/rspec-core#2627 rspec/rspec-core#2629 https://github.com/rspec/rspec-core/blob/master/Changelog.md#300rc1--2014-05-18 > Breaking Changes for 3.0.0: > Change described_class so that in a nested group like describe > MyClass, it returns MyClass rather than the outer group's described > class.
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…-examples-doc Fix documentation for nested described_class
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…ed_class-in-nested-examples-doc Fix documentation for nested described_class --- This commit was imported from rspec/rspec-core@d04d4de.
pirj
added a commit
to rubocop/rubocop-capybara
that referenced
this pull request
Dec 29, 2022
RSpec is actually setting the innermost described class as `described_class`, not the top-level one: rspec/rspec-core#2627 rspec/rspec-core#2629 https://github.com/rspec/rspec-core/blob/master/Changelog.md#300rc1--2014-05-18 > Breaking Changes for 3.0.0: > Change described_class so that in a nested group like describe > MyClass, it returns MyClass rather than the outer group's described > class.
ydah
pushed a commit
to rubocop/rubocop-factory_bot
that referenced
this pull request
Apr 13, 2023
RSpec is actually setting the innermost described class as `described_class`, not the top-level one: rspec/rspec-core#2627 rspec/rspec-core#2629 https://github.com/rspec/rspec-core/blob/master/Changelog.md#300rc1--2014-05-18 > Breaking Changes for 3.0.0: > Change described_class so that in a nested group like describe > MyClass, it returns MyClass rather than the outer group's described > class.
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
RSpec is actually setting the innermost described class as `described_class`, not the top-level one: rspec/rspec-core#2627 rspec/rspec-core#2629 https://github.com/rspec/rspec-core/blob/master/Changelog.md#300rc1--2014-05-18 > Breaking Changes for 3.0.0: > Change described_class so that in a nested group like describe > MyClass, it returns MyClass rather than the outer group's described > class.
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
RSpec is actually setting the innermost described class as `described_class`, not the top-level one: rspec/rspec-core#2627 rspec/rspec-core#2629 https://github.com/rspec/rspec-core/blob/master/Changelog.md#300rc1--2014-05-18 > Breaking Changes for 3.0.0: > Change described_class so that in a nested group like describe > MyClass, it returns MyClass rather than the outer group's described > class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2627
Documentation for
described_classwas out of date, a change was made in early 3.0 in #1361, but was not reflected to the docs.Also, documentation for implicit
subjectwas off, even though there is a feature describing how it behaves.