prettify shellwords usage

[rctay]

Since shellwords extends String with shellescape and shellsplit (corresponding to Shellwords::shellwords), we may omit blocks to map that just invoke those methods.

The &:inst_meth works on 1.8 too.

[coveralls]

Coverage increased (+0%) when pulling 71052bc on rctay:rc/shellwords into dee12fc on rspec:master.

[fables-tales]

I think this is good. @myronmarston I just wanted to double check. This doesn't need a changelog entry because it's just simple internal refactoring?

[JonRowe]

I believe we want to hold off on this to 3.0.0, I could be wrong but I think 1.8.6 has something to say about shellwords...

[rctay]

I gathered from the Gemfile that rspec-core requires at least 1.8.7, did I miss anything?

[JonRowe]

Master (Rspec 3) supports 1.8.7 and 1.9.2 and above but RSpec 2.14
nominally (to the point of it will parse and mostly run) supports 1.8.6

On Sunday, 23 June 2013, Tay Ray Chuan wrote:

I gathered from the Gemfile that rspec-core requires at least 1.8.7, did I
miss anything?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/951#issuecomment-19870580
.

[rctay]

Ok, as you pointed out in c8b6587, this may not work on 1.8.6.

[JonRowe]

Yep, FYI:

1.8.6 :001 > require 'shellwords'
 => true
1.8.6 :002 > "".shellsplit
NoMethodError: undefined method `shellsplit' for "":String
1.8.6 :003 > Shellwords.shellwords ""
 => []

So this is a master merge only...

[fables-tales]

I've come to the following conclusions: this is a good change for RSpec 3.0.0 and it doesn't need a Changelog entry. @rctay thanks for the contribution!

[JonRowe]

❤️

[rctay]

👍