Resolves rspec/rspec-core#950 and adds specs

[alindeman]

• Hopefully the code clarity is improved here
• We also change the behavior by not duping an object if space is
  not yet initialized. This should have been the behavior from the
  beginning, but it was overlooked and did not have specs.

[JonRowe]

I like it...

[coveralls]

Coverage remained the same when pulling 77b64fe on alindeman:issue-950-with-specs into 65745a0 on rspec:master.

[coveralls]

Coverage remained the same when pulling 77b64fe on alindeman:issue-950-with-specs into 65745a0 on rspec:master.

[myronmarston]

This isn't a merge blocker by any means, but I think if ::RSpec::Mocks.space.nil? is a bit clearer than if !::RSpec::Mocks.space. Not worth taking extra time to fixup, though, unless you wind up doing more work here for some other reason.

[myronmarston]

👍 Much better. Did you confirm your change fixes the spork issue? I expect it does (given that we now know that the old code would unnecessarily dup), but figured it was worth asking.

[alindeman]

Pushed new commits based on your comments.

👍 Much better. Did you confirm your change fixes the spork issue? I expect it does (given that we now know that the old code would unnecessarily dup), but figured it was worth asking.

Yep! I used your recurring_select repo. It's blowing up with TypeError on master, but works correctly on this branch.

Ready for re-review :)

[coveralls]

Coverage remained the same when pulling ed527b9 on alindeman:issue-950-with-specs into 65745a0 on rspec:master.

[myronmarston]

LGTM. I guess this just needs a changelog and to be merged into the appropriate branches.

[JonRowe]

❤️

[coveralls]

Coverage remained the same when pulling bcee056 on alindeman:issue-950-with-specs into 65745a0 on rspec:master.