Skip to content

Add Ruby 3.2 to the CI matrix #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Add Ruby 3.2 to the CI matrix #2648

merged 2 commits into from
Jan 6, 2023

Conversation

ydah
Copy link
Contributor

@ydah ydah commented Jan 4, 2023

This PR is add Ruby 3.2 to the CI matrix
Because Ruby 3.2.0 is now in general release, it makes sense to add Ruby 3.2 to the CI matrix.

https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/

@pirj
Copy link
Member

pirj commented Jan 4, 2023

It seems that we’re missing ruby2_keywords call somewhere

@ydah ydah force-pushed the add-ruby32 branch 2 times, most recently from 6bc99b7 to 5e3eda5 Compare January 4, 2023 11:06
@ydah
Copy link
Contributor Author

ydah commented Jan 4, 2023

The following issue seem to be occurring

Occurring errors:
https://github.com/rspec/rspec-rails/actions/runs/3837276670/jobs/6532393278#step:7:43

  1. Configuration clears ActionMailer::Base::Deliveries after each example only has deliveries from this test (e.g. from email@example.com)
    Got 0 failures and 2 other errors:

    1.1) Failure/Error:
    def welcome(to:)
    mail(to: to, subject: 'subject', body: render(inline: "Hello", layout: false))
    end

      ArgumentError:
        wrong number of arguments (given 1, expected 0; required keyword: to)
    

@ydah ydah marked this pull request as ready for review January 5, 2023 15:52
Comment on lines 67 to 69
# Rails 6.1 builds >= 2.5
# Not applicable for ruby 3.2 as it is not supported.
# See: https://github.com/rails/rails/issues/46883#issuecomment-1371325906
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[memo]

Rails 6.1 only receives security bug fixes. At the moment it doesn't work with Ruby 3.2.
rails/rails#46883 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to mention this, we only support supported Ruby versions for currently maintained Rails

Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert formatting changes to .github/workflows/ci.yml

@ydah ydah requested a review from JonRowe January 6, 2023 14:46
@ydah
Copy link
Contributor Author

ydah commented Jan 6, 2023

Thank you for your review. I updated this PR.

ydah added a commit to ydah/rspec-expectations that referenced this pull request Jan 6, 2023
ydah added a commit to ydah/rspec-core that referenced this pull request Jan 6, 2023
ydah added a commit to ydah/rspec-support that referenced this pull request Jan 6, 2023
ydah added a commit to ydah/rspec-its that referenced this pull request Jan 6, 2023
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JonRowe JonRowe merged commit a0099fc into rspec:main Jan 6, 2023
JonRowe pushed a commit that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants