-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Ruby 3.2 to the CI matrix #2648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that we’re missing ruby2_keywords call somewhere |
6bc99b7
to
5e3eda5
Compare
The following issue seem to be occurring Occurring errors:
|
.github/workflows/ci.yml
Outdated
# Rails 6.1 builds >= 2.5 | ||
# Not applicable for ruby 3.2 as it is not supported. | ||
# See: https://github.com/rails/rails/issues/46883#issuecomment-1371325906 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[memo]
Rails 6.1 only receives security bug fixes. At the moment it doesn't work with Ruby 3.2.
rails/rails#46883 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to mention this, we only support supported Ruby versions for currently maintained Rails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert formatting changes to .github/workflows/ci.yml
Thank you for your review. I updated this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* Add Ruby 3.2 to the CI matrix * Change to install past Rubygems and Bundler if less than Ruby 2.6 https://github.com/rubygems/rubygems/releases/tag/bundler-v2.4.0 https://github.com/rubygems/rubygems/releases/tag/v3.4.0
This PR is add Ruby 3.2 to the CI matrix
Because Ruby 3.2.0 is now in general release, it makes sense to add Ruby 3.2 to the CI matrix.
https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/