Don't mutate ActionView::PathSet [6-0-maintenance backport] #2651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows rails/rails@0371317. ActionView::PathSet no longer responds to unshift or push. We could copy the new implementation, but we've chosen to delegate to it instead. Co-authored-by: Iliana Hadzhiatanasova <me@iliana.dev>
eugeneius
changed the title
|
Thanks for pointing this out, taken care of with a manual cherry-pick. |
|
FYI, backporting #2648 will fix the failing Ruby 2.5 job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2631 comprised two commits; the second was backported to 6-0-maintenance as bd2bb24, but the first wasn't.
CI on 6-0-maintenance is still failing for Rails main:
https://github.com/rspec/rspec-rails/actions/runs/3345336900/jobs/5540735966#step:7:50