Skip to content

Conversation

antn
Copy link
Contributor

@antn antn commented Feb 1, 2015

Hey there,

This PR adds the .ignorejekyll, which according to the pages documentation will solve the issue in #49 where the _index.html pages 404.

Of course, as the name of the file suggests, this will disable jekyll, although from what I see you aren't using it at all since middleman compiles everything into a static site.

myronmarston added a commit that referenced this pull request Feb 1, 2015
add .nojekyll to allow _index pages, closes #49
@myronmarston myronmarston merged commit b50eaeb into rspec:source Feb 1, 2015
@antn antn deleted the disable-jekyll branch February 1, 2015 03:04
@myronmarston
Copy link
Member

Thanks! I deployed this, but it doesn't seem to have fixed the issue. Still, it's a good change regardless. I suspect that there's an additional step we need to do. Middleman assumes files starting with underscores are partials and thus doesn't make them available for direct access. We need to look into a middleman config option to be able to specify that certain directories contain no partials and files starting with _ should be treated as normal files.

@antn
Copy link
Contributor Author

antn commented Feb 1, 2015

It also looks like the .nojekyll also didn't actually get added to the master branch – not sure why. Thought that maybe middleman was ignoring it but it should be in the whitelist.

As for the issue with middleman seeing those files as partials, I'll submit a PR here pretty soon to fix that, as I just found the config option for that.

@antn
Copy link
Contributor Author

antn commented Feb 1, 2015

Found out why the .nojekyll wasn't working; I had forgotten to put it in the source folder! oops! Should be fixed in #56.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants