Skip to content

Conversation

@jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Feb 26, 2016

Mostly minor sentence construction tweaks, typos, and using words instead of digits for small numbers.

I also added a couple of mentions that you might want to use Shiny not only for inputs, but also for automatic updates using reactiveFileReader/reactivePoll.

Two more things:

  • I think the Shiny page needs a mention of renderPlot; I don't think the static plots will actually resize without this.
  • Once there is a section for renderPlot, there's a link I added under "Figure sizes and scaling" that needs to be updated (currently it's shiny.html#TODO).

@jcheng5
Copy link
Member Author

jcheng5 commented Feb 26, 2016

Oh and also, I didn't actually build, I just updated the .Rmd files blind.

jjallaire added a commit that referenced this pull request Feb 27, 2016
@jjallaire jjallaire merged commit 51696de into gh-pages Feb 27, 2016
@jjallaire
Copy link
Member

Here's the change I made for renderPlot:

183cd14

I didn't add a full section but I didn't feel that there was enough content
for that. Did you have something more in mind?

On Fri, Feb 26, 2016 at 6:16 PM, Joe Cheng notifications@github.com wrote:

Oh and also, I didn't actually build, I just updated the .Rmd files blind.


Reply to this email directly or view it on GitHub
#2 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants