Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into useful-error-msgs
* master: (23 commits) Improve color handling and add tests (#870) Change HTML percent sign to literal `%` (#871) Add ability to set global locale in `gt()` (#866) Bug fixes and enhancements to date/time formatters (#801) Update gt_workflow_diagram.svg Update gt_parts_of_a_table.svg Update README.md Add dedicated ISSUE TEMPLATEs Update README.md Delete README.Rmd Update intro-creating-gt-tables.Rmd Update LICENSE Make corrections to docs (`columns`/`rows`) Update _pkgdown.yml Fixes to footer (footnotes and source notes) across all output formats (#864) Row group labels as a column in stub (#855) Use reusable GHA workflows (#847) Increment version number v0.3.1 Release Candidate (#821) Fix for styles applied to summary cells when row groups are reordered (#814) ...
- Loading branch information
Showing
104 changed files
with
17,010 additions
and
4,543 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
inst/graphics/test_image.svg -text |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
--- | ||
name: Bug | ||
about: Something is wrong with gt. | ||
title: '' | ||
labels: 'Type: ☹︎ Bug' | ||
assignees: rich-iannone | ||
--- | ||
|
||
## Prework | ||
|
||
* [ ] Read and agree to the [code of conduct](https://www.contributor-covenant.org/version/2/0/code_of_conduct/) and [contributing guidelines](https://github.com/rstudio/gt/blob/master/.github/CONTRIBUTING.md). | ||
* [ ] If there is [already a relevant issue](https://github.com/rstudio/gt/issues), whether open or closed, comment on the existing thread instead of posting a new issue. | ||
* [ ] Post a [minimal reproducible example](https://www.tidyverse.org/help/) so the maintainer can troubleshoot the problems you identify. A reproducible example is: | ||
* [ ] **Runnable**: post enough R code and data so any onlooker can create the error on their own computer. | ||
* [ ] **Minimal**: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand. | ||
* [ ] **Readable**: format your code according to the [tidyverse style guide](https://style.tidyverse.org/). | ||
|
||
## Description | ||
|
||
Describe the bug clearly and concisely. | ||
|
||
## Reproducible example | ||
|
||
* [ ] Post a [minimal reproducible example](https://www.tidyverse.org/help/) so the maintainer can troubleshoot the problems you identify. A reproducible example is: | ||
* [ ] **Runnable**: post enough R code and data so any onlooker can create the error on their own computer. | ||
* [ ] **Minimal**: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand. | ||
* [ ] **Readable**: format your code according to the [tidyverse style guide](https://style.tidyverse.org/). | ||
|
||
## Expected result | ||
|
||
What should have happened? Please be as specific as possible. | ||
|
||
## Session info | ||
|
||
End the reproducible example with a call to `sessionInfo()` in the same session (e.g. `reprex(session_info = TRUE)`) and include the output. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
name: New feature | ||
about: Suggest a new feature. | ||
title: '' | ||
labels: 'Type: ★ Enhancement' | ||
assignees: rich-iannone | ||
--- | ||
|
||
## Prework | ||
|
||
- [ ] Read and abide by **gt**'s [code of conduct](https://www.contributor-covenant.org/version/2/0/code_of_conduct/) and [contributing guidelines](https://github.com/rstudio/gt/blob/master/.github/CONTRIBUTING.md). | ||
- [ ] Search for duplicates among the [existing issues](https://github.com/rstudio/gt/issues) (both open and closed). | ||
|
||
## Proposal | ||
|
||
Describe the new feature clearly and concisely. If applicable, write a minimal example in R code or pseudo-code to show input, usage, and desired output. | ||
|
||
To help us read any code you include (optional) please try to follow the [tidyverse style guide](https://style.tidyverse.org/). The `style_text()` and `style_file()` functions from the [`styler`](https://github.com/r-lib/styler) package make it easier. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
--- | ||
name: Question | ||
about: Ask a question. | ||
title: '' | ||
labels: 'Type: ⁇ Question' | ||
assignees: '' | ||
--- | ||
|
||
## Prework | ||
|
||
* [ ] Read and agree to the [code of conduct](https://www.contributor-covenant.org/version/2/0/code_of_conduct/) and [contributing guidelines](https://github.com/rstudio/gt/blob/master/.github/CONTRIBUTING.md). | ||
* [ ] If there is [already a relevant issue](https://github.com/rstudio/gt/issues), whether open or closed, comment on the existing thread instead of posting a new issue. | ||
* [ ] For any problems you identify, a [minimal reproducible example](https://www.tidyverse.org/help/) so the maintainer can troubleshoot. A reproducible example is: | ||
* [ ] **Runnable**: post enough R code and data so any onlooker can create the error on their own computer. | ||
* [ ] **Minimal**: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand. | ||
* [ ] **Readable**: format your code according to the [tidyverse style guide](https://style.tidyverse.org/). | ||
|
||
## Question | ||
|
||
What would you like to know? | ||
|
||
## Reproducible example | ||
|
||
* [ ] For any problems you identify, post a [minimal reproducible example](https://www.tidyverse.org/help/) so the maintainer can troubleshoot. A reproducible example is: | ||
* [ ] **Runnable**: post enough R code and data so any onlooker can create the error on their own computer. | ||
* [ ] **Minimal**: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand. | ||
* [ ] **Readable**: format your code according to the [tidyverse style guide](https://style.tidyverse.org/). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,107 +1,21 @@ | ||
# Workflow derived from https://github.com/rstudio/shiny-workflows | ||
# | ||
# NOTE: This Shiny team GHA workflow is overkill for most R packages. | ||
# For most R packages it is better to use https://github.com/r-lib/actions | ||
on: | ||
push: | ||
branches: | ||
- master | ||
branches: [main, master, rc-**] | ||
pull_request: | ||
branches: | ||
- master | ||
branches: [main, master] | ||
schedule: | ||
- cron: '0 2 * * 1' # every monday | ||
|
||
name: R-CMD-check | ||
name: Package checks | ||
|
||
jobs: | ||
website: | ||
uses: rstudio/shiny-workflows/.github/workflows/website.yaml@v1 | ||
routine: | ||
uses: rstudio/shiny-workflows/.github/workflows/routine.yaml@v1 | ||
R-CMD-check: | ||
runs-on: ${{ matrix.config.os }} | ||
|
||
name: ${{ matrix.config.os }} (${{ matrix.config.r }}) | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
config: | ||
- {os: macOS-latest, r: '3.5'} | ||
- {os: macOS-latest, r: '3.6'} | ||
- {os: macOS-latest, r: '4.0'} | ||
- {os: windows-latest, r: '3.6'} | ||
- {os: windows-latest, r: '4.0'} | ||
- {os: ubuntu-16.04, r: '3.5', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"} | ||
- {os: ubuntu-16.04, r: '3.6', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"} | ||
- {os: ubuntu-16.04, r: '4.0', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"} | ||
|
||
env: | ||
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true | ||
_R_CHECK_FORCE_SUGGESTS_: false | ||
RSPM: ${{ matrix.config.rspm }} | ||
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- uses: r-lib/actions/setup-r@master | ||
with: | ||
r-version: ${{ matrix.config.r }} | ||
|
||
- uses: r-lib/actions/setup-pandoc@master | ||
|
||
- name: Query dependencies | ||
run: | | ||
install.packages('remotes') | ||
saveRDS(remotes::dev_package_deps(dependencies = TRUE), ".github/depends.Rds", version = 2) | ||
shell: Rscript {0} | ||
|
||
- name: Cache R packages | ||
if: runner.os != 'Windows' | ||
uses: actions/cache@v1 | ||
with: | ||
path: ${{ env.R_LIBS_USER }} | ||
key: ${{ runner.os }}-r-${{ matrix.config.r }}-2-${{ hashFiles('.github/depends.Rds') }} | ||
restore-keys: ${{ runner.os }}-r-${{ matrix.config.r }}-2- | ||
|
||
- name: Problematic Pkgs | ||
shell: Rscript {0} | ||
run: | | ||
remotes::install_cran("htmltools") | ||
remotes::install_cran("ellipsis") | ||
remotes::install_cran("pillar") | ||
remotes::install_cran("ps") | ||
remotes::install_cran("processx") | ||
- name: Install system dependencies | ||
if: runner.os == 'Linux' | ||
env: | ||
RHUB_PLATFORM: linux-x86_64-ubuntu-gcc | ||
run: | | ||
Rscript -e "remotes::install_github('r-hub/sysreqs')" | ||
sysreqs=$(Rscript -e "cat(sysreqs::sysreq_commands('DESCRIPTION'))") | ||
sudo -s eval "$sysreqs" | ||
- name: Install dependencies | ||
run: | | ||
if (Sys.info()[["sysname"]] == "Windows") { | ||
options(install.packages.compile.from.source = "never") | ||
} | ||
remotes::install_deps(dependencies = TRUE) | ||
remotes::install_cran("rcmdcheck") | ||
shell: Rscript {0} | ||
|
||
- name: Install rcmdcheck | ||
shell: Rscript {0} | ||
run: | | ||
remotes::install_cran("rcmdcheck") | ||
- name: Check | ||
env: | ||
_R_CHECK_CRAN_INCOMING_: false | ||
run: rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning", check_dir = "check") | ||
shell: Rscript {0} | ||
|
||
- name: Upload check results | ||
if: failure() | ||
uses: actions/upload-artifact@master | ||
with: | ||
name: ${{ runner.os }}-r${{ matrix.config.r }}-results | ||
path: check | ||
|
||
- name: Test coverage | ||
if: matrix.config.os == 'macOS-latest' && matrix.config.r == '3.6' | ||
run: covr::codecov() | ||
shell: Rscript {0} | ||
uses: rstudio/shiny-workflows/.github/workflows/R-CMD-check.yaml@v1 |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
YEAR: 2018-2021 | ||
YEAR: 2018-2022 | ||
COPYRIGHT HOLDER: RStudio, PBC |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.