Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Norwegian translation. #806

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Add Norwegian translation. #806

merged 3 commits into from
Nov 13, 2023

Conversation

jonovik
Copy link
Contributor

@jonovik jonovik commented Nov 10, 2023

Added Norwegian translation.

image

---
title: "Norsk oversettelse"
output:
  learnr::tutorial:
    language: "no"
runtime: shiny_prerendered
---

```{r exercise, exercise=TRUE}
"ÆØÅ"
```

Running devtools::check() gives the same four test failures as main.

PR task list:

  • Update NEWS
  • [] Did not add tests (not done for other translations either)
  • [] No need to update documentation (devtools::document() did not make any changes)

Details

For my translation to take effect, it appears I had to manually run data-raw/i18n_translations.R to regenerate inst/internals/i18n_translations.rds and inst/internals/i18n_random_phrases.rds.
I added a comment about this to the top of data-raw/i18n_translations.yml.

Updated vignettes/multilang.Rmd:

  • Note that language code "no" needs to be quoted because it is a reserved word in YAML.
  • Fixed two small bugs:
    • The list of available languages meant to append "(default)" to English, but did not store the result.
    • "zh" was not followed by "Chinese" because the test lng %in% names(languages) fails to match the "zh" in the YAML files in data-raw with the "zh_CN" and "zh_TW" names() defined in the vignette.

Fixed missing capitalization in "(All exercise progress will be reset") in data-raw/i18n_translations.yml.

Fixed typo in "Perseverance" in data-raw/i18n_random_phrases.yml.

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the translation and for the additional copy edits!

NEWS.md Outdated Show resolved Hide resolved
@gadenbuie gadenbuie modified the milestones: v0.11.1, Next Release Nov 13, 2023
@gadenbuie gadenbuie merged commit aeb8144 into rstudio:main Nov 13, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants