Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Norwegian translation.
Running
devtools::check()
gives the same four test failures asmain
.PR task list:
devtools::document()
did not make any changes)Details
For my translation to take effect, it appears I had to manually run
data-raw/i18n_translations.R
to regenerateinst/internals/i18n_translations.rds
andinst/internals/i18n_random_phrases.rds
.I added a comment about this to the top of
data-raw/i18n_translations.yml
.Updated
vignettes/multilang.Rmd
:"no"
needs to be quoted because it is a reserved word in YAML.lng %in% names(languages)
fails to match the "zh" in the YAML files indata-raw
with the "zh_CN" and "zh_TW" names() defined in the vignette.Fixed missing capitalization in "(All exercise progress will be reset") in
data-raw/i18n_translations.yml
.Fixed typo in "Perseverance" in
data-raw/i18n_random_phrases.yml
.