Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let packrat use renv for dependency analysis #548

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Conversation

aronatkins
Copy link
Contributor

@aronatkins aronatkins commented Nov 8, 2021

requires rstudio/packrat#647

Automatically enables the packrat.dependency.discovery.renv option, requesting that packrat use renv for dependency analysis. An existing value for packrat.dependency.discovery.renv is left alone.

@aronatkins aronatkins requested a review from kevinushey November 8, 2021 13:57
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aronatkins aronatkins force-pushed the aron-packrat-use-renv branch from 0ab0eda to 097fe73 Compare November 12, 2021 18:56
@aronatkins aronatkins force-pushed the aron-packrat-use-renv branch from 097fe73 to 4b383cd Compare November 12, 2021 18:58
@aronatkins aronatkins marked this pull request as ready for review November 12, 2021 19:11
@aronatkins
Copy link
Contributor Author

@kevinushey Any concerns with including this in rsconnect ahead of a possible packrat release?

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aronatkins aronatkins merged commit 250aa5c into main Nov 12, 2021
@aronatkins aronatkins deleted the aron-packrat-use-renv branch November 12, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants