Skip to content

Conversation

chama1176
Copy link
Contributor

@chama1176 chama1176 commented Jul 2, 2024

What does this implement/fix?

ROS 2 Jazzyに対応します

  • Jazzyでビルドが通るように修正しました
    • 過去のバージョンでもビルドが通ることはCIで確認済みです
  • CIにJazzyを追加しました
    • 合わせてどこかのバージョンでCIがコケてもCI全体を止めないようにMatrixの設定を変更しています
  • READMEにJazzy対応を追加

Does this close any currently open issues?

いいえ

How has this been tested?

CIでビルドが通ることを確認。
実機でx7_forward_kinematicsのサンプルを実行しエラーが出ないことを確認しました

Any other comments?

Checklists

@chama1176 chama1176 changed the base branch from main to ros2 July 2, 2024 00:18
@chama1176 chama1176 marked this pull request as ready for review July 2, 2024 05:02
@chama1176 chama1176 requested a review from Kuwamai July 2, 2024 05:03
@Kuwamai Kuwamai added the Type: Feature New Feature label Aug 7, 2024
Copy link

@Kuwamai Kuwamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。
authorタグに名前の追加をお願いします。

https://github.com/rt-net/rt_manipulators_cpp/blob/feature/support-jazzy/rt_manipulators_examples/package.xml#L10

@chama1176
Copy link
Contributor Author

@Kuwamai
確認ありがとうございます
examplesの方は変更していないのでlibの方だけauthorタグに追加させていただきます(こちらも変更少しだけですが)

@chama1176
Copy link
Contributor Author

chama1176 commented Aug 8, 2024

追加してrosdep installのみ再確認しました

Copy link

@Kuwamai Kuwamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。

@Kuwamai Kuwamai merged commit 01d9425 into ros2 Aug 9, 2024
@Kuwamai Kuwamai deleted the feature/support-jazzy branch August 9, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants