Close #2884 #2886
Merged
Close #2884 #2886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retailcoder
reviewed
Mar 17, 2017
| return ((ICodeExplorerDeclarationViewModel) node)?.Declaration; | ||
| } | ||
|
|
||
| private string GetFolder(object parameter) |
retailcoder
reviewed
Mar 17, 2017
|
|
||
| protected override void ExecuteImpl(object parameter) | ||
| { | ||
| var folderAnnotation = $"'@Folder(\"{GetFolder(parameter)}\")"; |
There was a problem hiding this comment.
Hmm.. Should we have a "default folder" setting? That way it wouldn't need to be duplicated in every module-creating command...
retailcoder
reviewed
Mar 17, 2017
|
|
||
| protected override void ExecuteImpl(object parameter) | ||
| { | ||
| var folderAnnotation = $"'@Folder(\"{GetFolder(parameter)}\")"; |
There was a problem hiding this comment.
We need to figure out a way to have this work when the module is added via standard VBE commands too... somehow.
retailcoder
reviewed
Mar 17, 2017
| } | ||
|
|
||
| return node == null ? null : ((ICodeExplorerDeclarationViewModel)node).Declaration; | ||
| return ((ICodeExplorerDeclarationViewModel) node)?.Declaration; |
There was a problem hiding this comment.
Perhaps extract some ModuleMaker type that the commands would use for this? That way the relatively complex logic below would only be in one place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like how these three commands each implement an identical
GetDeclarationandGetFolder.