Fix an incorrect autocorrect for Capybara/PathExpectation
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
changed the title
Capybara/PathExpectation when register an offense with matchCapybara/PathExpectation
This PR is fix an incorrect autocorrect for `Capybara/PathExpectation`. ```diff -expect(page).to have_current_path `pwd` +expect(page).to have_current_path `pwd`, ignore_query: true expect(page).to have_current_path "/callback" \ - "/foo" + "/foo", ignore_query: true ```
ydah
force-pushed
the
fix-autocorrect-CurrentPathExpectation
branch
from
315d45c to
e325a75
Compare
This was referenced Jan 9, 2023
pirj
approved these changes
Jan 9, 2023
| end | ||
|
|
||
| it 'flags violations for `expect(current_path)` with a `command`' do | ||
| expect_offense(<<~'RUBY') |
There was a problem hiding this comment.
Is quoting of RUBY necessary in this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fix an incorrect autocorrect for
Capybara/PathExpectation.Before submitting the PR make sure the following are checked:
main(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).