Fix a false positive and incorrect autocorrect for RSpec/Capybara/SpecificActions, RSpec/Capybara/SpecificFinders and RSpec/Capybara/SpecificMatcher

[ydah]

Fix: rubocop/rubocop-capybara#4

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• [-] Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[Tietew]

CSS selector [visible] means the element has an attribute named visible (e.g. <span visible="yes">), NOT "the element is actually visible". CSS does not have :visible pseudo-class --- it's a jQuery's extension.
And also, [focused] means the element has an attribute named focused, NOT "the element is now focused". :focus pseudo-class should be used instead.

[ydah]

That is indeed true. I guess I was mistaken. Thanks for pointing that out to me.

[ydah]

I updated this PR.

[pirj]

I can't tell much about those cops, just that there were no errors:

$ rubocop --only RSpec/Capybara/MatchStyle --only RSpec/Capybara/SpecificActions --only RSpec/Capybara/SpecificFinders --only RSpec/Capybara/SpecificMatcher ../real-world-rspec
...
/Users/pirj/source/real-world-rspec/solidus/backend/spec/features/admin/orders/order_details_spec.rb:175:31: C: RSpec/Capybara/SpecificMatcher: Prefer have_field over have_css.
          expect(page).not_to have_css("input")
                              ^^^^^^^^^^^^^^^^^
57497 files inspected, 63 offenses detected

Thank you!

PS In the output there were only offences from RSpec/Capybara/SpecificMatcher, so I intend to re-run it again. It might be rubocop only accepts one --only 🤔

[pirj]

/Users/pirj/source/real-world-rspec/solidus/frontend/spec/features/checkout_spec.rb:359:14: C: [Correctable] RSpec/Capybara/SpecificFinders: Prefer find_by over find.
      expect(find("#use_existing_card_yes")).to be_checked
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

57497 files inspected, 336 offenses detected, 336 offenses autocorrectable

for the other

[pirj]

/Users/pirj/source/real-world-rspec/publify/publify_core/spec/features/drafting_articles_spec.rb:25:5: C: RSpec/Capybara/SpecificActions: Prefer click_link over find('a').click.
    find('a[href="/admin/articles/1/edit"]').click
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

57497 files inspected, 63 offenses detected

[ydah]

I rebased this PR.

[bquorning]

I would really like to see some direct spec coverage of the mixins, especially lib/rubocop/cop/rspec/mixin/css_selector.rb. For a start, it could just test the mentioned @example lines of each method.

[bquorning]

This does not look right. Probably a shortcoming of us using regular expressions to parse CSS :-)

[pirj]

Please don't merge this just yet, I'm extracting rspec-capybara.

[pirj]

May I kindly ask to re-target this to rubocop-capybara, @ydah ?

[ydah]

@pirj OK, I'll do it 👍 It may take a little time as we add mixin testing as well.

[ydah]

We are now open and PR here is closed.
rubocop/rubocop-capybara#10