Skip to content

Adding features to Actors #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Jul 29, 2014
Merged

Adding features to Actors #132

merged 45 commits into from
Jul 29, 2014

Conversation

pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Jul 4, 2014

No description provided.

@pitr-ch pitr-ch self-assigned this Jul 4, 2014
@pitr-ch pitr-ch changed the title add lazy register for actors Adding features to Actors Jul 6, 2014
@jdantonio jdantonio mentioned this pull request Jul 6, 2014
49 tasks
@pitr-ch
Copy link
Member Author

pitr-ch commented Jul 7, 2014

@Papipo message redirecting added, but it also contains core modularization into behaviors. Tests are passing but other than that I've did not test it much.

pitr-ch added 11 commits July 8, 2014 08:27
Use global_task_executor to perform the task be default. Use
immediate executor in configuration related Delays before
global_task_executor is up an running.
actor will get notified when linked actor fails
keep Actress around for compatibility
to able to easily override default reference class
@jdantonio
Copy link
Member

This test suite is going to be the death of me...

I've added the failing spec to my list in Issue #117. I will work on it this week.

@pitr-ch
Copy link
Member Author

pitr-ch commented Jul 10, 2014

@jdantonio Thanks! I'll try to help when I finish with this PR.

@jdantonio
Copy link
Member

No sweat. The actor work you are doing is very important. I'm happy to handle the problematic specs so that you can stay focussed.

pitr-ch added 11 commits July 11, 2014 16:26
Actor.spawn or AnActor.spawn should be used instead as
it depends on global Actor.current. It's also more similar to
Kernel.spawn.
if nothing is scheduled execute the message right away do not pass
it to another scheduling block, saves context switching
`AnActor.spawn name: 'an', link: true` will be linked before any
message is received.
removing Context module in favor of Context class
pitr-ch added 6 commits July 13, 2014 13:23
to be able to add custom code invocation on events
like `:terminated`, `:resumed`, `anError`
allows to set handler: :reset!, :resume!, :terminate!
and strategies: :one_for_one, :one_for_all
as :reset but it also drops all messages
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.12%) when pulling 3cf3be7 on actress into 1ca7374 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) when pulling b17b70a on actress into 1ca7374 on master.

@pitr-ch
Copy link
Member Author

pitr-ch commented Jul 27, 2014

Hi Guys, I would like to merge this in one or two days. If you have a moment please review. I'll be on the Gitter if you have any questions.

@jdantonio
Copy link
Member

@pitr-ch I'm 100% on board with this PR. I've been following your conversations with @Papipo in Gitter and I'm extremely impressed with what you have done. The failed build in Travis is due to a problem Travis is having with Rbx for all builds, not just ours. I've added Rbx to the allowed failures list in our Travis config file.

Please feel free to merge whenever you are ready. Afterward I will create another RC build and push it to Rubygems.

If you have an opportunity, can you please add some detail to the changelog? I'd update it myself but I'm afraid I would miss important details.

@pitr-ch
Copy link
Member Author

pitr-ch commented Jul 29, 2014

@jdantonio thanks for you kind words. I've updated the changelog, please feel free to rephrase anything you would like to improve.

@pitr-ch
Copy link
Member Author

pitr-ch commented Jul 29, 2014

I'll resolve the conflicts and merge shortly.

* upstream/master: (13 commits)
  Temporarily adding Rbx to Travis allowed failure list due to problem with the Travis service.
  ...

Conflicts:
	lib/concurrent/atomic/thread_local_var.rb
pitr-ch pushed a commit that referenced this pull request Jul 29, 2014
@pitr-ch pitr-ch merged commit 06dc588 into master Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding features, adding tests, improving documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants