Warnings when using deprecated :overflow_policy thread pool option #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdantonio
added a commit
that referenced
this pull request
Dec 8, 2014
…warnings Warnings when using deprecated :overflow_policy thread pool option
| @@ -342,8 +342,8 @@ | |||
| end | |||
| end | |||
|
|
|||
| context '#overflow_policy' do | |||
| context ':caller_runs is honoured even if the old overflow_policy arg is used' do | |||
| context '#fallback_policy' do | |||
There was a problem hiding this comment.
Ah - this one wasn't something I accidentally missed. It's a test to make sure we're backwards-compatible with :overflow_policy.
There was a problem hiding this comment.
Ah. Sorry about that. That's what I get for doing is simple search/replace! :-) I'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:overflow_policyoption but display a warningFinished work began in PRs #199 and #201. Completes enhancement suggested in issue #192.