Skip to content

Add set_deref_options call to Promise constructor #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2014

Conversation

rkday
Copy link
Contributor

@rkday rkday commented Dec 13, 2014

Fixes unintitialised variable warnings, and matches delay.rb.

I spotted these warnings while (I think) waiting for a Promise to be fulfilled:

/home/rkd/.rvm/gems/ruby-2.1.5@diameter/gems/concurrent-ruby-0.7.1/lib/concurrent/dereferenceable.rb:101: warning: instance variable @do_nothing_on_deref not initialized
/home/rkd/.rvm/gems/ruby-2.1.5@diameter/gems/concurrent-ruby-0.7.1/lib/concurrent/dereferenceable.rb:102: warning: instance variable @copy_on_deref not initialized
/home/rkd/.rvm/gems/ruby-2.1.5@diameter/gems/concurrent-ruby-0.7.1/lib/concurrent/dereferenceable.rb:103: warning: instance variable @dup_on_deref not initialized
/home/rkd/.rvm/gems/ruby-2.1.5@diameter/gems/concurrent-ruby-0.7.1/lib/concurrent/dereferenceable.rb:104: warning: instance variable @freeze_on_deref not initialized

and saw that promise.rb was calling apply_deref_options (and documenting the relevant constructor values) but not set_deref_options.

Fixes unintitialised variable warnings, and matches delay.rb
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) when pulling 9d588f3 on rkday:promise_deref into 6af1316 on ruby-concurrency:master.

@jdantonio
Copy link
Member

Thank you!

jdantonio added a commit that referenced this pull request Dec 13, 2014
Add set_deref_options call to Promise constructor
@jdantonio jdantonio merged commit 5929b46 into ruby-concurrency:master Dec 13, 2014
@jdantonio jdantonio removed the unknown label Dec 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants