-
Notifications
You must be signed in to change notification settings - Fork 419
Added :args to Future and Promise options hash. #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following examples now work as expected: require 'concurrent'
value = 100
future = Concurrent::Future.execute(args: value) do |t_value|
sleep 1
t_value + 1
end
value = 200
p future.value #=> 101
value = (1..10).to_a
future = Concurrent::Future.execute(args: value) do |*t_value|
sleep 1
t_value << 1000
end
value = nil
p future.value #=> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 1000] |
makes sense to me! |
def execute | ||
if compare_and_set_state(:pending, :unscheduled) | ||
@executor.post{ work } | ||
@executor.post(@args){work } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: lost space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! :-)
LGTM |
a9dd938
to
e3e0501
Compare
jdantonio
added a commit
that referenced
this pull request
Jan 25, 2015
Added :args to Future and Promise options hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the enhancement discussed in #223. It adds an
:args
option to the constructor and factory ofFuture
andPromise
. The value of this option, when set, can be either a single value or an array of zero or more values. When theargs
option is given the values will be passed to the underlying executor and, subsequently, passed to the task block. Providing:args
isolates the scope of the variables so that they can be re-assigned within the closing scope. The passed variables are still mutable object references that can be modified within the task block.