Futures: passing args on construction, interoperability with channel, documentation #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitr-ch
added
the
enhancement
pitr-ch
force-pushed
the
futures
branch
2 times, most recently
from
1c65e49 to
ac25865
Compare
pitr-ch
changed the title
| end | ||
|
|
||
| # Schedules the block to be executed on executor in given intended_time. | ||
| # @return [Future] | ||
| def schedule(intended_time, default_executor = :io, &task) | ||
| ScheduledPromise.new(intended_time, default_executor).future.chain(&task) | ||
| def schedule(intended_time, *args, &task) |
There was a problem hiding this comment.
Can we list what types can be used with IntendedTime? This may have some implications if used with something like ActiveSupport, for example.
Closed
|
@pitr-ch Is this ready for merge? I would like to release pre2 this evening. |
|
merging, and updating changelog branch. There is some work left, but that can wait after pre2. |
pitr-ch
pushed a commit
that referenced
this pull request
Jun 7, 2015
Futures: passing args on construction, interoperability with channel, documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.