New Agent implementation. #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdantonio
added
the
enhancement
|
Does it integrate with TVar as well? |
|
It does not integrate with TVar. That will be documented in the Yardoc. |
jdantonio
force-pushed
the
new-agent
branch
3 times, most recently
from
10487e0 to
e68c0ae
Compare
| # ({#await}, {#await_for}, {#await_for!}, and {#wait}) from within an action | ||
| # block/proc/lambda. The call will block the Agent and will always fail. | ||
| # Calling either {#await} or {#wait} (with a timeout of `nil`) will | ||
| # hopelessly deadlock the Agent with no possibility of recovery. |
There was a problem hiding this comment.
Probably. Interestingly, this is exactly the same as Clojure. I was surprised that Clojure took this approach but it is documented behavior.
There was a problem hiding this comment.
Hm, I would not have expected that in clojure. I would raise if it can be already detected (to protect our users) otherwise let's keep it as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs yardoc, but functionally complete.