Skip to content

Sync updates #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 4, 2015
Merged

Sync updates #462

merged 6 commits into from
Nov 4, 2015

Conversation

jdantonio
Copy link
Member

See #459

  • Dereferenceable
  • Maybe
  • Tick
  • TVar (ensure_ivar_visibility! only)
  • MVar (ensure_ivar_visibility! only)

@jdantonio jdantonio added in progress enhancement Adding features, adding tests, improving documentation. labels Nov 3, 2015
@jdantonio jdantonio added this to the 1.0.0 Release milestone Nov 3, 2015
@jdantonio jdantonio self-assigned this Nov 3, 2015
@pitr-ch
Copy link
Member

pitr-ch commented Nov 3, 2015

Ah sorry I should have communicated it better, I had to remove #ensure_ivar_visibility! in favor of of .safe_initialization!. Subclassing with ensure_ivar_visibility! was leading to multiple barriers which is undesirable. See https://github.com/ruby-concurrency/concurrent-ruby/blob/master/lib/concurrent/synchronization/object.rb#L48 I've opened #464

jdantonio added a commit that referenced this pull request Nov 4, 2015
@jdantonio
Merge pull request #462 from ruby-concurrency/sync-updates
c690eb7 
Sync updates
@jdantonio jdantonio merged commit c690eb7 into master Nov 4, 2015
@jdantonio jdantonio deleted the sync-updates branch November 4, 2015 23:28
@pitr-ch
Copy link
Member

pitr-ch commented Nov 8, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdantonio jdantonio

Labels
enhancement Adding features, adding tests, improving documentation.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jdantonio @pitr-ch