Raise better error when input is not an IVar #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def call_dataflow(method, executor, *inputs, &block) | ||
| raise ArgumentError.new('an executor must be provided') if executor.nil? | ||
| raise ArgumentError.new('no block given') unless block_given? | ||
| raise ArgumentError.new('not all dependencies are IVars') unless inputs.all? { |input| input.is_a? IVar } | ||
| not_ivars = inputs.map { |input| !input.is_a? IVar } | ||
| unless not_ivars.empty? |
There was a problem hiding this comment.
@schneems Thank you for taking the time to work on this update. There are several failing tests we need to look into. I haven't had an opportunity to pull the code and run the tests locally, but I believe this line is the culprit. Won't the #map function create an array with a number of elements equal to the size of the inputs array? I think #empty? will always return false in this case. Can you please take a look?
There was a problem hiding this comment.
Yes, that should have been a select, it was right locally but not committed. I'm updating to not allocate an array on every run, will preserve the original logic.
schneems
force-pushed
the
schneems/better-ivar-error-message
branch
from
02e2861 to
6a8e4a1
Compare
This will show the values received such as: ``` rgumentError: Not all dependencies are IVars. Dependencies: [false] /Users/richardschneeman/.gem/ruby/2.3.0/gems/concurrent-ruby-1.0.0/lib/concurrent/dataflow.rb:61:in `call_dataflow' /Users/richardschneeman/.gem/ruby/2.3.0/gems/concurrent-ruby-1.0.0/lib/concurrent/dataflow.rb:40:in `dataflow_with' /Users/richardschneeman/.gem/ruby/2.3.0/gems/concurrent-ruby-1.0.0/lib/concurrent/dataflow.rb:35:in `dataflow' /Users/richardschneeman/Documents/projects/sprockets/lib/sprockets/manifest.rb:203:in `block in compile' /Users/richardschneeman/Documents/projects/sprockets/lib/sprockets/manifest.rb:131:in `block (2 levels) in find' /Users/richardschneeman/Documents/projects/sprockets/lib/sprockets/base.rb:76:in `find_all_linked_assets' /Users/richardschneeman/Documents/projects/sprockets/lib/sprockets/manifest.rb:130:in `block in find' /Users/richardschneeman/Documents/projects/sprockets/lib/sprockets/manifest.rb:129:in `each' /Users/richardschneeman/Documents/projects/sprockets/lib/sprockets/manifest.rb:129:in `find' /Users/richardschneeman/Documents/projects/sprockets/lib/sprockets/manifest.rb:164:in `compile' /Users/richardschneeman/.gem/ruby/2.3.0/bundler/gems/sprockets-rails-ad4a43bd1bb1/lib/sprockets/rails/task.rb:68:in `block (3 levels) in define' /Users/richardschneeman/Documents/projects/sprockets/lib/rake/sprocketstask.rb:147:in `with_logger' /Users/richardschneeman/.gem/ruby/2.3.0/bundler/gems/sprockets-rails-ad4a43bd1bb1/lib/sprockets/rails/task.rb:67:in `block (2 levels) in define' ```
schneems
force-pushed
the
schneems/better-ivar-error-message
branch
from
6a8e4a1 to
91c5f04
Compare
|
Updated to use the original logic, instead of only showing the non conforming inputs, we can easily show all of the inputs. By not using a |
Closed
|
Tests are back to passing |
|
👍 |
jdantonio
added a commit
that referenced
this pull request
Dec 8, 2015
Raise better error when input is not an IVar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will show the values received such as: