Implemented TimerSet executor and updated Concurrent::timer #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mighe I've updated Concurrent::timer based on your suggestion. I think this implementation is much better. Please feel free to update if you think it can be optimized more. Here's what I did:
MutexPriorityQueue
class based on Sedgewick and WayneJavaPriorityQueue
wrapper forjava.util.PriorityQueue
PriorityQueue
class that maps to either the Ruby or Java implementation as appropriateTimerSet
executor that follows your suggested algorithm (puts all tasks in a priority queue based on absolute time then posts tasks to a thread pool)TimerSet
such as lazy starting of the monitor thread, letting the monitor thread die when not being used, and support for the:executor
option on constructionConcurrent::timer
to aTimerSet